]> git.ipfire.org Git - thirdparty/linux.git/commit
HID: logitech-dj: Remove duplicate error logging
authorHans de Goede <johannes.goede@oss.qualcomm.com>
Sat, 8 Nov 2025 21:03:18 +0000 (22:03 +0100)
committerJiri Kosina <jkosina@suse.com>
Wed, 26 Nov 2025 15:16:34 +0000 (16:16 +0100)
commitca389a55d8b2d86a817433bf82e0602b68c4d541
tree037c7dbc236a1155eecb9c2f41c35820aed089ec
parenta78eb69d60ce893de48dd75f725ba21309131fc2
HID: logitech-dj: Remove duplicate error logging

logi_dj_recv_query_paired_devices() and logi_dj_recv_switch_to_dj_mode()
both have 2 callers which all log an error if the function fails. Move
the error logging to inside these 2 functions to remove the duplicated
error logging in the callers.

While at it also move the logi_dj_recv_send_report() call error handling
in logi_dj_recv_switch_to_dj_mode() to directly after the call. That call
only fails if the report cannot be found and in that case it does nothing,
so the msleep() is not necessary on failures.

Fixes: 6f20d3261265 ("HID: logitech-dj: Fix error handling in logi_dj_recv_switch_to_dj_mode()")
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-logitech-dj.c