]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ata: libata-core: fix NULL pointer deref in ata_host_alloc_pinfo()
authorSergey Shtylyov <s.shtylyov@omp.ru>
Sat, 21 May 2022 20:34:10 +0000 (23:34 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Jun 2022 09:45:17 +0000 (11:45 +0200)
commitca4693e6e06e4fd2b240c0fec47aa2498c94848e
tree7855917c34b6987f4afe2663cd84938d069b3ae8
parentef78edd4ef7ac0fe0c04f999bbba76dbac6567ff
ata: libata-core: fix NULL pointer deref in ata_host_alloc_pinfo()

[ Upstream commit bf476fe22aa1851bab4728e0c49025a6a0bea307 ]

In an unlikely (and probably wrong?) case that the 'ppi' parameter of
ata_host_alloc_pinfo() points to an array starting with a NULL pointer,
there's going to be a kernel oops as the 'pi' local variable won't get
reassigned from the initial value of NULL. Initialize 'pi' instead to
'&ata_dummy_port_info' to fix the possible kernel oops for good...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/ata/libata-core.c