]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Drop @cmdret argument from qemuSecurityCommandRun()
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 13 Feb 2023 11:27:49 +0000 (12:27 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 3 Mar 2023 11:02:59 +0000 (12:02 +0100)
commitcaa25f75cfb1f37a504eadb35d6d9efea43aeff7
tree350d4238c1489b26391b5911886bf0b731c46881
parent17ffdbab1f8df9ee14588e4d86d60874d482399b
qemu: Drop @cmdret argument from qemuSecurityCommandRun()

Every single caller of qemuSecurityCommandRun() calls the
function as:

  if (qemuSecurityCommandRun(..., &cmdret) < 0)
      goto cleanup;

  if (cmdret < 0)
      goto cleanup;

(modulo @exitstatus shenanigans)

Well, there's no need for such complication. There isn't a single
caller (and probably will never be (TM)), that would need to
distinguish the reason for the failure. Therefore,
qemuSecurityCommandRun() can be made to pass the retval of
virCommandRun() called under the hood.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_dbus.c
src/qemu/qemu_passt.c
src/qemu/qemu_security.c
src/qemu/qemu_security.h
src/qemu/qemu_slirp.c
src/qemu/qemu_tpm.c
src/qemu/qemu_vhost_user_gpu.c