]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
IB/iser: Fix memory regions possible leak
authorSagi Grimberg <sagig@mellanox.com>
Sun, 18 Jan 2015 14:51:06 +0000 (16:51 +0200)
committerSasha Levin <sasha.levin@oracle.com>
Tue, 24 Mar 2015 01:02:44 +0000 (21:02 -0400)
commitcaa2a1adfedfa16ce25f4230d814f425b25b9630
tree41216c37e7ccf131e38589b86d067ff3924514c5
parentbbc56fba25d6a3ff29224503702614e311cc8e77
IB/iser: Fix memory regions possible leak

commit 6606e6a2ff2710b473838b291dc533cd8fc1471f upstream.

When teardown process starts during live IO, we need to keep the
memory regions pool (frmr/fmr) until all in-flight tasks are properly
released, since each task may return a memory region to the pool. In
order to do this, we pass a destroy flag to iser_free_ib_conn_res to
indicate we can destroy the device and the memory regions
pool. iser_conn_release will pass it as true and also DEVICE_REMOVAL
event (we need to let the device to properly remove).

Also, Since we conditionally call iser_free_rx_descriptors,
remove the extra check on iser_conn->rx_descs.

Fixes: 5426b1711fd0 ("IB/iser: Collapse cleanup and disconnect handlers")
Reported-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/infiniband/ulp/iser/iser_initiator.c
drivers/infiniband/ulp/iser/iser_verbs.c