]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mlxsw: spectrum: Fix memory leak in mlxsw_sp_flower_stats()
authorZilin Guan <zilin@seu.edu.cn>
Wed, 12 Nov 2025 05:21:14 +0000 (05:21 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Dec 2025 21:12:38 +0000 (06:12 +0900)
commitcab341c5cf65d7df188ef982bb7998f0670e9867
treec87a5204ec3f655481babdeccd9e58ea12127a32
parent55c9312830dd11dff66146f9fcc201a76f49de22
mlxsw: spectrum: Fix memory leak in mlxsw_sp_flower_stats()

[ Upstream commit 407a06507c2358554958e8164dc97176feddcafc ]

The function mlxsw_sp_flower_stats() calls mlxsw_sp_acl_ruleset_get() to
obtain a ruleset reference. If the subsequent call to
mlxsw_sp_acl_rule_lookup() fails to find a rule, the function returns
an error without releasing the ruleset reference, causing a memory leak.

Fix this by using a goto to the existing error handling label, which
calls mlxsw_sp_acl_ruleset_put() to properly release the reference.

Fixes: 7c1b8eb175b69 ("mlxsw: spectrum: Add support for TC flower offload statistics")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20251112052114.1591695-1-zilin@seu.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c