]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix pg_upgrade around multixid and mxoff wraparound
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 12 Nov 2025 10:20:16 +0000 (12:20 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 12 Nov 2025 10:23:55 +0000 (12:23 +0200)
commitcb2ef0e92edb9710e599d0a8b1f850fb46859787
tree4139dafdef920252b239473fb5f7927d9def8444
parentd5c32753b033d7aa62382dfe4b10b0c2699b6ee1
Fix pg_upgrade around multixid and mxoff wraparound

pg_resetwal didn't accept multixid 0 or multixact offset UINT32_MAX,
but they are both valid values that can appear in the control file.
That caused pg_upgrade to fail if you tried to upgrade a cluster
exactly at multixid or offset wraparound, because pg_upgrade calls
pg_resetwal to restore multixid/offset on the new cluster to the
values from the old cluster. To fix, allow those values in
pg_resetwal.

Fixes bugs #18863 and #18865 reported by Dmitry Kovalenko.

Backpatch down to v15. Version 14 has the same bug, but the patch
doesn't apply cleanly there. It could be made to work but it doesn't
seem worth the effort given how rare it is to hit this problem with
pg_upgrade, and how few people are upgrading to v14 anymore.

Author: Maxim Orlov <orlovmg@gmail.com>
Discussion: https://www.postgresql.org/message-id/CACG%3DezaApSMTjd%3DM2Sfn5Ucuggd3FG8Z8Qte8Xq9k5-%2BRQis-g@mail.gmail.com
Discussion: https://www.postgresql.org/message-id/18863-72f08858855344a2@postgresql.org
Discussion: https://www.postgresql.org/message-id/18865-d4c66cf35c2a67af@postgresql.org
Backpatch-through: 15
src/bin/pg_resetwal/pg_resetwal.c
src/bin/pg_resetwal/t/001_basic.pl