]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
comedi: 8255: Add some I/O base address sanity checks
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:47:27 +0000 (16:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:36 +0000 (15:49 +0200)
commitcb51837eeeddac2da41f4c202597c534bb9d8dc9
tree4e0fa21cc854fabca6c96d74a12eb44348e879d2
parent241cb8dee0f83856c728f4fe2c29e331386c92f2
comedi: 8255: Add some I/O base address sanity checks

The "8255" driver allows a COMEDI device to be constructed from one or
more 8255 chips, each at an I/O port base address specified by the
admin-supplied configuration options (`it->options[]`).  Currently, the
driver allows any I/O base addresses to be specified as long as the I/O
regions can be reserved, and it converts the specified `int` option
values holding the base address to `unsigned long`.

It doesn't make sense to allow base addresses that are not aligned to
4-byte boundaries because the hardware register addresses would not be
decoded properly, so add a check for valid alignment.

Convert the option values that specify the base addresses from `int` to
`unsigned int` instead of `unsigned long` so they end up the same on
32-bit and 64-bit systems.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-3-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/8255.c