]> git.ipfire.org Git - thirdparty/linux.git/commit
cifs: Fix memory and information leak in smb3_reconfigure()
authorZilin Guan <zilin@seu.edu.cn>
Wed, 24 Dec 2025 15:21:42 +0000 (15:21 +0000)
committerSteve French <stfrench@microsoft.com>
Wed, 24 Dec 2025 17:07:15 +0000 (11:07 -0600)
commitcb6d5aa9c0f10074f1ad056c3e2278ad2cc7ec8d
tree0697b10bf81f9b79284665840bae715e8ac8c1c0
parent9448598b22c50c8a5bb77a9103e2d49f134c9578
cifs: Fix memory and information leak in smb3_reconfigure()

In smb3_reconfigure(), if smb3_sync_session_ctx_passwords() fails, the
function returns immediately without freeing and erasing the newly
allocated new_password and new_password2. This causes both a memory leak
and a potential information leak.

Fix this by calling kfree_sensitive() on both password buffers before
returning in this error case.

Fixes: 0f0e357902957 ("cifs: during remount, make sure passwords are in sync")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/fs_context.c