]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Remove some unnecessary optimizations in popcount code.
authorNathan Bossart <nathan@postgresql.org>
Thu, 12 Feb 2026 17:32:49 +0000 (11:32 -0600)
committerNathan Bossart <nathan@postgresql.org>
Thu, 12 Feb 2026 17:32:49 +0000 (11:32 -0600)
commitcb7b2e5e8efb3e5fb08052425cd00f067a56f877
treef2c8e474b69c82e8a63d245eef1eada7ffe60988
parent88327092ff06c48676d2a603420089bf493770f3
Remove some unnecessary optimizations in popcount code.

Over the past few releases, we've added a huge amount of complexity
to our popcount implementations.  Commits fbe327e5b479e232ca01,
8c6653516c, and 25dc485074 did some preliminary refactoring, but
many opportunities remain.  In particular, if we disclaim interest
in micro-optimizing this code for 32-bit builds and in unnecessary
alignment checks on x86-64, we can remove a decent chunk of code.
I cannot find public discussion or benchmarks for the code this
commit removes,  but it seems unlikely that this change will
noticeably impact performance on affected systems.

Suggested-by: John Naylor <johncnaylorls@gmail.com>
Reviewed-by: John Naylor <johncnaylorls@gmail.com>
Discussion: https://postgr.es/m/CANWCAZY7R%2Biy%2Br9YM_sySNydHzNqUirx1xk0tB3ej5HO62GdgQ%40mail.gmail.com
src/include/port/pg_bitutils.h
src/port/pg_bitutils.c
src/port/pg_popcount_x86.c