]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: sd: Do not attempt to configure discard unless LBPME is set
authorMartin K. Petersen <martin.petersen@oracle.com>
Sat, 17 Aug 2024 00:53:10 +0000 (20:53 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 17 Aug 2024 01:16:49 +0000 (21:16 -0400)
commitcbaac68987b8699397df29413b33bd51f5255255
tree460ad206a5c952ece54c18bb3e6bf82372dd67d0
parentcd612b57c3672487ae8565855eaf9e83862eccc5
scsi: sd: Do not attempt to configure discard unless LBPME is set

Commit f874d7210d88 ("scsi: sd: Keep the discard mode stable") attempted
to address an issue where one mode of discard operation got configured
prior to the device completing full discovery.  Unfortunately this
change assumed discard was always enabled on the device.

Do not attempt to configure discard unless LBPME is enabled.

Link: https://lore.kernel.org/r/20240817005325.3319384-1-martin.petersen@oracle.com
Fixes: f874d7210d88 ("scsi: sd: Keep the discard mode stable")
Reported-by: Chris Bainbridge <chris.bainbridge@gmail.com>
Tested-by: Chris Bainbridge <chris.bainbridge@gmail.com>
Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Tested-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c