]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
NFS: Fix READ_PLUS when server doesn't support OP_READ_PLUS
authorAnna Schumaker <Anna.Schumaker@Netapp.com>
Thu, 25 Apr 2024 20:24:29 +0000 (16:24 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:47:47 +0000 (13:47 +0200)
commitcbc4dacaa5b1923065a8273aaecd7c46367995e4
tree6d986a6d17b733f7525a4c6d1c7641b0e3a9d2b2
parentd6ea0e12befb21a23e0a9471e6ede6fb0c11c708
NFS: Fix READ_PLUS when server doesn't support OP_READ_PLUS

commit f06d1b10cb016d5aaecdb1804fefca025387bd10 upstream.

Olga showed me a case where the client was sending multiple READ_PLUS
calls to the server in parallel, and the server replied
NFS4ERR_OPNOTSUPP to each. The client would fall back to READ for the
first reply, but fail to retry the other calls.

I fix this by removing the test for NFS_CAP_READ_PLUS in
nfs4_read_plus_not_supported(). This allows us to reschedule any
READ_PLUS call that has a NFS4ERR_OPNOTSUPP return value, even after the
capability has been cleared.

Reported-by: Olga Kornievskaia <kolga@netapp.com>
Fixes: c567552612ec ("NFS: Add READ_PLUS data segment support")
Cc: stable@vger.kernel.org # v5.10+
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/nfs4proc.c