]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ceph: fix memory leaks in __ceph_sync_read()
authorMax Kellermann <max.kellermann@ionos.com>
Thu, 5 Dec 2024 15:49:51 +0000 (16:49 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Dec 2024 13:02:19 +0000 (14:02 +0100)
commitcbd952b2c4e6eb5dcfdb931e74eff1607f31b496
treed2afec9f29978563380b98f5acaa621d7f476943
parent28433d0b7b29558fb3543fa49bfd675c8fe80edd
ceph: fix memory leaks in __ceph_sync_read()

commit d6fd6f8280f0257ba93f16900a0d3d3912f32c79 upstream.

In two `break` statements, the call to ceph_release_page_vector() was
missing, leaking the allocation from ceph_alloc_page_vector().

Instead of adding the missing ceph_release_page_vector() calls, the
Ceph maintainers preferred to transfer page ownership to the
`ceph_osd_request` by passing `own_pages=true` to
osd_req_op_extent_osd_data_pages().  This requires postponing the
ceph_osdc_put_request() call until after the block that accesses the
`pages`.

Cc: stable@vger.kernel.org
Fixes: 03bc06c7b0bd ("ceph: add new mount option to enable sparse reads")
Fixes: f0fe1e54cfcf ("ceph: plumb in decryption during reads")
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ceph/file.c