]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
raw: fix a typo in raw_icmp_error()
authorEric Dumazet <edumazet@google.com>
Thu, 23 Jun 2022 19:35:40 +0000 (19:35 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 13:16:19 +0000 (15:16 +0200)
commitcbfe2d7bbcb7b50f7da42cd22fef5ed5a388dc68
treef31b1a80e90ecf15438e3914cefc0959ab37661c
parent3476fa73bd0f9dc8f38f238273a43a13d3a09b15
raw: fix a typo in raw_icmp_error()

commit 97a4d46b1516250d640c1ae0c9e7129d160d6a1c upstream.

I accidentally broke IPv4 traceroute, by swapping iph->saddr
and iph->daddr.

Probably because raw_icmp_error() and raw_v4_input()
use different order for iph->saddr and iph->daddr.

Fixes: ba44f8182ec2 ("raw: use more conventional iterators")
Reported-by: John Sperbeck <jsperbeck@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220623193540.2851799-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/raw.c