]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iscsi-target: Fix iscsit_start_kthreads failure OOPs
authorNicholas Bellinger <nab@linux-iscsi.org>
Thu, 23 Jul 2015 06:14:19 +0000 (23:14 -0700)
committerSasha Levin <sasha.levin@oracle.com>
Thu, 27 Aug 2015 17:25:53 +0000 (13:25 -0400)
commitcc25280443deb9c421eef5914ca739012bf99375
tree4cade2b44db81714df4e82fdb5fe24ee07fe61e7
parent36ac1d14682122e3d792c66c8ae8d6d1bd093547
iscsi-target: Fix iscsit_start_kthreads failure OOPs

[ Upstream commit e54198657b65625085834847ab6271087323ffea ]

This patch fixes a regression introduced with the following commit
in v4.0-rc1 code, where a iscsit_start_kthreads() failure triggers
a NULL pointer dereference OOPs:

    commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca
    Author: Nicholas Bellinger <nab@linux-iscsi.org>
    Date:   Thu Feb 26 22:19:15 2015 -0800

        iscsi-target: Convert iscsi_thread_set usage to kthread.h

To address this bug, move iscsit_start_kthreads() immediately
preceeding the transmit of last login response, before signaling
a successful transition into full-feature-phase within existing
iscsi_target_do_tx_login_io() logic.

This ensures that no target-side resource allocation failures can
occur after the final login response has been successfully sent.

Also, it adds a iscsi_conn->rx_login_comp to allow the RX thread
to sleep to prevent other socket related failures until the final
iscsi_post_login_handler() call is able to complete.

Cc: Sagi Grimberg <sagig@mellanox.com>
Cc: <stable@vger.kernel.org> # v3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/target/iscsi/iscsi_target.c
drivers/target/iscsi/iscsi_target_core.h
drivers/target/iscsi/iscsi_target_login.c
drivers/target/iscsi/iscsi_target_login.h
drivers/target/iscsi/iscsi_target_nego.c