]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
firmware_loader: fix memory leak for paged buffer
authorPrateek Sood <prsood@codeaurora.org>
Thu, 20 Aug 2020 20:57:50 +0000 (02:27 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Sep 2020 10:59:49 +0000 (12:59 +0200)
commitcc283bfae1f0da6ace501838d4f36ddbda1d3a1e
treef654e9383f3503e41c249d560d93ed9c6086fd8c
parent3531913b68be7356575279e32cc2d944bf6d3df6
firmware_loader: fix memory leak for paged buffer

commit 4965b8cd1bc1ffb017e5c58e622da82b55e49414 upstream.

vfree() is being called on paged buffer allocated
using alloc_page() and mapped using vmap().

Freeing of pages in vfree() relies on nr_pages of
struct vm_struct. vmap() does not update nr_pages.
It can lead to memory leaks.

Fixes: ddaf29fd9bb6 ("firmware: Free temporary page table after vmapping")
Signed-off-by: Prateek Sood <prsood@codeaurora.org>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/1597957070-27185-1-git-send-email-prsood@codeaurora.org
Cc: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_loader/firmware.h
drivers/base/firmware_loader/main.c