]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ACPICA: Fix memory leak caused by _CID repair function
authorErik Kaneda <erik.kaneda@intel.com>
Fri, 4 Jun 2021 21:25:57 +0000 (14:25 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:15:46 +0000 (16:15 +0200)
commitcc346f84e15189ab3b0453d8aad8471fdb9ad28e
tree15e475021c305294f2ba33f42c4b868eefe4b4b2
parentaf02ec6cf6142bff7a2497c7fee83d0386379953
ACPICA: Fix memory leak caused by _CID repair function

[ Upstream commit c27bac0314131b11bccd735f7e8415ac6444b667 ]

ACPICA commit 180cb53963aa876c782a6f52cc155d951b26051a

According to the ACPI spec, _CID returns a package containing
hardware ID's. Each element of an ASL package contains a reference
count from the parent package as well as the element itself.

Name (TEST, Package() {
    "String object" // this package element has a reference count of 2
})

A memory leak was caused in the _CID repair function because it did
not decrement the reference count created by the package. Fix the
memory leak by calling acpi_ut_remove_reference on _CID package elements
that represent a hardware ID (_HID).

Link: https://github.com/acpica/acpica/commit/180cb539
Tested-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/acpica/nsrepair2.c