]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
rust: device: change the from_raw() function
authorGuilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Tue, 1 Oct 2024 20:56:03 +0000 (17:56 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Oct 2024 11:54:48 +0000 (13:54 +0200)
commitcc4332afb5631b0e9d2ce5699b7f4b7caf743526
tree0caae4576c3d14923e7a47279565bf4911f5b32f
parent9852d85ec9d492ebef56dc5f229416c925758edc
rust: device: change the from_raw() function

The function Device::from_raw() increments a refcount by a call to
bindings::get_device(ptr). This can be confused because usually
from_raw() functions don't increment a refcount.
Hence, rename Device::from_raw() to avoid confuion with other "from_raw"
semantics.

The new name of function should be "get_device" to be consistent with
the function get_device() already exist in .c files.

This function body also changed, because the `into()` will convert the
`&'a Device` into `ARef<Device>` and also call `inc_ref` from the
`AlwaysRefCounted` trait implemented for Device.

Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Acked-by: Danilo Krummrich <dakr@kernel.org>
Closes: https://github.com/Rust-for-Linux/linux/issues/1088
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20241001205603.106278-1-trintaeoitogc@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
rust/kernel/device.rs
rust/kernel/firmware.rs