]> git.ipfire.org Git - thirdparty/linux.git/commit
PCI/ERR: Remove remnants of .link_reset() callback
authorLukas Wunner <lukas@wunner.de>
Wed, 13 Aug 2025 05:11:05 +0000 (07:11 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 13 Aug 2025 18:21:02 +0000 (13:21 -0500)
commitcc4a7a21e815f81f782506d9f554ff2158e70ce8
tree68fefc47ebce9485482dcf9b53fe08a2b13eea1e
parent45bc82563d5505327d97963bc54d3709939fa8f8
PCI/ERR: Remove remnants of .link_reset() callback

Back in 2017, commit 2fd260f03b6a ("PCI/AER: Remove unused .link_reset()
callback") removed .link_reset() from struct pci_error_handlers, but left
a few code comments behind which still mention it.  Remove them.

The code comments in the SolarFlare Ethernet drivers point out that no
.mmio_enabled() callback is needed because the driver's .error_detected()
callback always returns PCI_ERS_RESULT_NEED_RESET, which causes
pcie_do_recovery() to skip .mmio_enabled().  That's not quite correct
because efx_io_error_detected() does return PCI_ERS_RESULT_RECOVERED under
certain conditions and then .mmio_enabled() would indeed be called if it
were implemented.  Remove this misleading portion of the code comment as
well.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/1d72a891a7f57115e78a73046e776f7e0c8cd68f.1755008151.git.lukas@wunner.de
drivers/net/ethernet/sfc/efx_common.c
drivers/net/ethernet/sfc/falcon/efx.c
drivers/net/ethernet/sfc/siena/efx_common.c
drivers/scsi/lpfc/lpfc_init.c