]> git.ipfire.org Git - thirdparty/elfutils.git/commit
libdw: Initialize tu_offset in __libdw_package_index
authorMark Wielaard <mark@klomp.org>
Fri, 1 Mar 2024 16:05:16 +0000 (17:05 +0100)
committerMark Wielaard <mark@klomp.org>
Fri, 1 Mar 2024 16:08:39 +0000 (17:08 +0100)
commitcc6e53b9f305148bda275ade40c0e625d98da2f2
tree22773039c98af20e582a2bdc418166231a93fd55
parent3979362ef98db16d1c6fe8fb12ee6a966305da49
libdw: Initialize tu_offset in __libdw_package_index

dwarf_cu_dwp_section_info.c: In function ‘__libdw_package_index’:
dwarf_cu_dwp_section_info.c:306:25: error: ‘tu_offset’ may be used uninitialized [-Werror=maybe-uninitialized]
  306 |               tu_offset += tu_index->section_count * 4;
      |               ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dwarf_cu_dwp_section_info.c:268:28: note: ‘tu_offset’ was declared here
  268 |       const unsigned char *tu_offset;
      |                            ^~~~~~~~~

Which is the same issue we thought to have fixed by checking for
tu_index != NULL but not all gcc versions seem able to see that.
So just explicitly initialize tu_offset to NULL. We keep the older
check, so the NULL pointer should never be used.

       * libdw/dwarf_cu_dwp_section_info.c (__libdw_package_index):
       Initialize tu_offset.

Signed-off-by: Mark Wielaard <mark@klomp.org>
libdw/dwarf_cu_dwp_section_info.c