]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
xfs: use null daddr for unset first bad log block
authorYousef Alhouseen <alhouseenyousef@gmail.com>
Tue, 30 Jun 2026 10:06:07 +0000 (12:06 +0200)
committerCarlos Maiolino <cem@kernel.org>
Wed, 1 Jul 2026 09:39:32 +0000 (11:39 +0200)
commitcc9af5e461ea5f6e37738f3f1e41c45a9b7f45d6
treecf12bb3cf3ed7a484c7c166a047f483b33dcd9d1
parent45de375b25060edf46e20abb36521ba530336ceb
xfs: use null daddr for unset first bad log block

xlog_do_recovery_pass() may return before setting first_bad.  The caller
must distinguish that case from an error at a valid log block, including
block zero after the log wraps.

Initialize first_bad to XFS_BUF_DADDR_NULL and test it explicitly before
treating the error as a torn write.

Fixes: 7088c4136fa1 ("xfs: detect and trim torn writes during log recovery")
Suggested-by: Darrick J. Wong <djwong@kernel.org>
Reported-by: syzbot+b7dfbed0c6c2b5e9fd34@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=b7dfbed0c6c2b5e9fd34
Cc: stable@vger.kernel.org # v4.5
Signed-off-by: Yousef Alhouseen <alhouseenyousef@gmail.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_log_recover.c