]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
crypto: starfive - Fix memory leak in starfive_aes_aead_do_one_req()
authorZilin Guan <zilin@seu.edu.cn>
Thu, 29 Jan 2026 15:10:16 +0000 (15:10 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 6 Feb 2026 10:52:22 +0000 (18:52 +0800)
commitccb679fdae2e62ed92fd9acb25ed809c0226fcc6
tree7214f627e56cacddbc5e827d143ad4402986aa5e
parentcd576c831e86f48f7cdc7a658d6596fe7be46ae2
crypto: starfive - Fix memory leak in starfive_aes_aead_do_one_req()

The starfive_aes_aead_do_one_req() function allocates rctx->adata with
kzalloc() but fails to free it if sg_copy_to_buffer() or
starfive_aes_hw_init() fails, which lead to memory leaks.

Since rctx->adata is unconditionally freed after the write_adata
operations, ensure consistent cleanup by freeing the allocation in these
earlier error paths as well.

Compile tested only. Issue found using a prototype static analysis tool
and code review.

Fixes: 7467147ef9bf ("crypto: starfive - Use dma for aes requests")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/starfive/jh7110-aes.c