]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sparc: fix error handling in scan_one_device()
authorMa Ke <make24@iscas.ac.cn>
Sat, 20 Sep 2025 12:53:12 +0000 (20:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 19 Oct 2025 14:23:15 +0000 (16:23 +0200)
commitccf6af67347d2a2d0198e66634a469c2f8d14a10
tree615d89d5b8d1abd030f831bd90c8f74e02445ee9
parentd2a7b3e29ff0c788f4253a8a7db0c84d36c9800a
sparc: fix error handling in scan_one_device()

commit 302c04110f0ce70d25add2496b521132548cd408 upstream.

Once of_device_register() failed, we should call put_device() to
decrement reference count for cleanup. Or it could cause memory leak.
So fix this by calling put_device(), then the name can be freed in
kobject_cleanup().

Calling path: of_device_register() -> of_device_add() -> device_add().
As comment of device_add() says, 'if device_add() succeeds, you should
call device_del() when you want to get rid of it. If device_add() has
not succeeded, use only put_device() to drop the reference count'.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: cf44bbc26cf1 ("[SPARC]: Beginnings of generic of_device framework.")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Signed-off-by: Andreas Larsson <andreas@gaisler.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/sparc/kernel/of_device_32.c
arch/sparc/kernel/of_device_64.c