]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix TestLib::slurp_file() with offset on windows.
authorAndres Freund <andres@anarazel.de>
Mon, 4 Oct 2021 20:28:06 +0000 (13:28 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 4 Oct 2021 20:33:08 +0000 (13:33 -0700)
commitcd1b2334b8a2c18f54e7ade408c9133805cae557
tree42963741e7343650ef4be9084dfa6d34b52e0003
parent07873a5dc925059fc76ddfd81db9a545faf06d33
Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921
src/test/perl/TestLib.pm