]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
8139too: revisit napi_complete_done() usage
authorEric Dumazet <edumazet@google.com>
Mon, 18 Sep 2017 20:03:43 +0000 (13:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Oct 2017 09:56:03 +0000 (11:56 +0200)
commitcd7e604ae80dc15cbabd278b1c8a0da4403233f1
tree5209122680054b439d5aa555d18fdbcb7dcc64e0
parent46b75a3199e8e486b73aee050aaf96e01c4c8bac
8139too: revisit napi_complete_done() usage

[ Upstream commit 129c6cda2de2a8ac44fab096152469999b727faf ]

It seems we have to be more careful in napi_complete_done()
use. This patch is not a revert, as it seems we can
avoid bug that Ville reported by moving the napi_complete_done()
test in the spinlock section.

Many thanks to Ville for detective work and all tests.

Fixes: 617f01211baf ("8139too: use napi_complete_done()")
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/realtek/8139too.c