]> git.ipfire.org Git - thirdparty/linux.git/commit
arm64: dts: rockchip: fix PHY handling for ROCK 4D
authorSebastian Reichel <sebastian.reichel@collabora.com>
Fri, 4 Jul 2025 17:31:59 +0000 (19:31 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 10 Jul 2025 09:00:14 +0000 (11:00 +0200)
commitcd803da7c033e376a66793a43ee98e136bc6cc25
tree964060d540521c1cca02910db717c15fc99e63eb
parent06b29cb849bc0437edd68373a1e8152f0bcd30e7
arm64: dts: rockchip: fix PHY handling for ROCK 4D

Old revisions of the ROCK 4D board have a dedicated crystal to
supply the RTL8211F PHY's 25MHz clock input. At least some newer
revisions instead use REFCLKO25M_GMAC0_OUT. The DT already has
this half-prepared, but there are some issues:

1. The DT relies on auto-selecting the right PHY driver, which
   requires that it works good enough to read the ID registers.
   This does not work without the clock, which is handled by
   the PHY driver. By updating the compatible to contain the
   RTL8211F IDs, so that the operating system can choose the
   right PHY driver without relying on a pre-powered PHY.

2. Despite the name REFCLKO25M_GMAC0_OUT could also provide a
   different frequency, so ensure it is explicitly set to 25
   MHz as expected by the PHY.

3. While at it switch from deprecated "enable-gpio" to standard
   "enable-gpios".

Fixes: a0fb7eca9c09 ("arm64: dts: rockchip: Add Radxa ROCK 4D device tree")
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Link: https://lore.kernel.org/r/20250704-rk3576-rock4d-phy-handling-fixes-v1-1-1d64130c4139@kernel.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts