]> git.ipfire.org Git - thirdparty/libvirt.git/commit
glibcompat: remove obsolete clang workaround
authorDaniel P. Berrangé <berrange@redhat.com>
Mon, 12 Aug 2024 09:53:19 +0000 (10:53 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Mon, 12 Aug 2024 10:52:57 +0000 (11:52 +0100)
commitcd9709a6ab034e6d6f44a5fa86c88466b64415e6
tree18da055ee0aad6dd5dedb6f0a9c9e605fe836379
parent71f14351f9b6ef3294c86df22751a7eaf019b4e2
glibcompat: remove obsolete clang workaround

This mostly reverts commit 65491a2dfe00bfcf9f09a8d6eab60234b56c8cc4.

There was a bug introduced in glib 2.67.0 which impacted libvirt with
clang causing -Wincompatible-pointer-types-discards-qualifiers warnings.

This was actually fixed quite quickly in 2.67.1 with

 https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719

Our workaround was then broken with glib 2.81.1 due to commit
14b3d5da9019150d821f6178a075d85044b4c255 changing the signature of the
(private) macro we were overriding.

Since odd-number glib releases are development snapshots, and the
original problem was only present in 2.67.0 and no other releases,
just drop the workaround entirely.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/util/glibcompat.h