]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mm/damon/sysfs: check DAMOS regions update progress from before_terminate()
authorSeongJae Park <sj@kernel.org>
Sat, 7 Oct 2023 20:04:32 +0000 (20:04 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Nov 2023 08:37:00 +0000 (09:37 +0100)
commitcdb4daffc2d428f2ea5ffa7fb388e82792eeb518
treeb7c5998f72290e0593467a3b3b6e4d8eff006ba6
parenta5c9f62896253d8d83bb674c7eaadc18ff23780c
mm/damon/sysfs: check DAMOS regions update progress from before_terminate()

commit 76b7069bcc89dec33f03eb08abee165d0306b754 upstream.

DAMON_SYSFS can receive DAMOS tried regions update request while kdamond
is already out of the main loop and before_terminate callback
(damon_sysfs_before_terminate() in this case) is not yet called.  And
damon_sysfs_handle_cmd() can further be finished before the callback is
invoked.  Then, damon_sysfs_before_terminate() unlocks damon_sysfs_lock,
which is not locked by anyone.  This happens because the callback function
assumes damon_sysfs_cmd_request_callback() should be called before it.
Check if the assumption was true before doing the unlock, to avoid this
problem.

Link: https://lkml.kernel.org/r/20231007200432.3110-1-sj@kernel.org
Fixes: f1d13cacabe1 ("mm/damon/sysfs: implement DAMOS tried regions update command")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org> [6.2.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/damon/sysfs.c