]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs: improve dquot iteration for scrub
authorDarrick J. Wong <djwong@kernel.org>
Mon, 15 Apr 2024 23:07:39 +0000 (16:07 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Wed, 17 Apr 2024 21:06:25 +0000 (14:06 -0700)
commitcdc6bcb83e43752884ad7771a1aca2b5b7883be8
tree59bf762dff259929ec0a24dd0e4095d9e58d0ee2
parentf76f73b3bbb6db2ef6a3518a97f56436d16d5630
xfs: improve dquot iteration for scrub

Source kernel commit: 21d7500929c8a0b10e22a6755850c6f9a9280284

Upon a closer inspection of the quota record scrubber, I noticed that
dqiterate wasn't actually walking all possible dquots for the mapped
blocks in the quota file.  This is due to xfs_qm_dqget_next skipping all
XFS_IS_DQUOT_UNINITIALIZED dquots.

For a fsck program, we really want to look at all the dquots, even if
all counters and limits in the dquot record are zero.  Rewrite the
implementation to do this, as well as switching to an iterator paradigm
to reduce the number of indirect calls.

This enables removal of the old broken dqiterate code from xfs_dquot.c.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
libxfs/xfs_format.h