]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
spi: spi-qpic-snand: remove superfluous qcom_spi_set_read_loc() calls
authorGabor Juhos <j4g8y7@gmail.com>
Sat, 29 Nov 2025 10:29:27 +0000 (11:29 +0100)
committerMark Brown <broonie@kernel.org>
Sun, 14 Dec 2025 10:39:26 +0000 (19:39 +0900)
commitcde4e63e847b4d41f017c2beb119c2668106a88a
treece1202fb66f7a89c31ae9b2c4eea27f98d7a2ba8
parent781c3e71c94c80e1b33a7d84b970907dd32abc10
spi: spi-qpic-snand: remove superfluous qcom_spi_set_read_loc() calls

Before configuring the registers related to page read, both the
qcom_spi_read_page_ecc() and the qcom_spi_read_page_oob() functions
are calling qcom_spi_set_read_loc() to set the read location for the
first codeword.

However the qcom_spi_set_read_loc() function puts the passed value
into the register write cache only, from where those gets written
to the corresponding register later via DMA.

Yet, the qcom_spi_set_read_loc() is also gets called within the
internal loops, and during the first iteration the read location
register values written by the initial call gets overwritten in
the register cache.

This means that the values written by the first calls are never
getting used in practice, so remove the calls as those are
superfluous.

Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://patch.msgid.link/20251129-qpic-snand-superfluous-readloc-v1-1-b84ca17095d9@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qpic-snand.c