]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vfs: make AIO use the proper rw_verify_area() area helpers
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 21 May 2012 23:06:20 +0000 (16:06 -0700)
committerWilly Tarreau <w@1wt.eu>
Sat, 12 Mar 2016 13:25:41 +0000 (14:25 +0100)
commitcde5406e80c478bf89b6c2874f02126ba37a7d91
tree32522936ee912c03bd1dc6018b09c5dacb1f787e
parente3dea3074f18a0c1dca8b6328b6bba0af3d61349
vfs: make AIO use the proper rw_verify_area() area helpers

commit a70b52ec1aaeaf60f4739edb1b422827cb6f3893 upstream.

We had for some reason overlooked the AIO interface, and it didn't use
the proper rw_verify_area() helper function that checks (for example)
mandatory locking on the file, and that the size of the access doesn't
cause us to overflow the provided offset limits etc.

Instead, AIO did just the security_file_permission() thing (that
rw_verify_area() also does) directly.

This fixes it to do all the proper helper functions, which not only
means that now mandatory file locking works with AIO too, we can
actually remove lines of code.

Reported-by: Manish Honap <manish_honap_vit@yahoo.co.in>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Willy Tarreau <w@1wt.eu>
fs/aio.c