]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
misc: remove ineffective WARN_ON() check from misc_deregister()
authorXion Wang <xion.wang@mediatek.com>
Wed, 27 Aug 2025 02:41:00 +0000 (10:41 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Sep 2025 17:41:07 +0000 (19:41 +0200)
commitceda408c0d1d41094ad125332c6fb1d488e61c0c
tree69551c50eb17eb0430e17b50a8d83a7fbca41de4
parent20f2044bae1187f58863c7aa3d07dfc6ba50afec
misc: remove ineffective WARN_ON() check from misc_deregister()

The WARN_ON(list_empty(&misc->list)) in misc_deregister() does
not catch any practical error conditions:
- For statically allocated miscdevice structures, the list pointers
 are zero-initialized, so list_empty() returns false, not true.
- After list_del(), the pointers are set to LIST_POISON1 and LIST_POISON2,
 so repeated deregistration also fails to trigger the check.

Signed-off-by: Xion Wang <xion.wang@mediatek.com>
Link: https://lore.kernel.org/r/20250827024201.21407-2-xion.wang@mediatek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/misc.c