]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write
authorColin Ian King <colin.king@canonical.com>
Tue, 14 Jan 2020 14:40:31 +0000 (14:40 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Feb 2020 18:53:05 +0000 (19:53 +0100)
commitcf0ea974b6a2c9308149f747db0ab30de1b5d36b
tree3d17ff31e7a579dfb063d1be8449f832b66908ed
parent5e9f573dc8e788ecfaaf3eb4f2d24ccc0f040de2
drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write

commit e0354d147e5889b5faa12e64fa38187aed39aad4 upstream.

The end of buffer check is off-by-one since the check is against
an index that is pre-incremented before a store to buf[]. Fix this
adjusting the bounds check appropriately.

Addresses-Coverity: ("Out-of-bounds write")
Fixes: 51bd6f291583 ("Add support for IPMB driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Message-Id: <20200114144031.358003-1-colin.king@canonical.com>
Reviewed-by: Asmaa Mnebhi <asmaa@mellanox.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/ipmi/ipmb_dev_int.c