]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virshtest: use virCommand instead of custom impl
authorJán Tomko <jtomko@redhat.com>
Sun, 9 Feb 2020 01:00:06 +0000 (02:00 +0100)
committerJán Tomko <jtomko@redhat.com>
Tue, 11 Feb 2020 15:30:18 +0000 (16:30 +0100)
commitcf17015fde9894aa9cd326afb61f05a726b782fe
tree6c08295bed8ff4f91abbe679f93486bf90e33aad
parent8bacdde9d538b4636a303982ecddf55c6f39ff9a
virshtest: use virCommand instead of custom impl

Our virCommand helper API already has the ability to capture
program output, there's no need to open-code it.

Apart from simplifying the code, the test is marginally faster
due to recent improvements in virCommandMassClose.

Until now, both stderr and stdout were stored in the same buffer.
This change stores stderr separately and expects it to be empty
for all the tests we currently run.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
tests/virshtest.c