]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commit
openssh: drop rejected patch fixed in 8.6p1 release
authorJose Quaresma <quaresma.jose@gmail.com>
Tue, 16 Jul 2024 14:16:37 +0000 (15:16 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 18 Jul 2024 16:21:01 +0000 (17:21 +0100)
commitcf193ea67ca852e76b19a7997b62f043b1bca8a1
tree8adda2e3ba0b25cd547f6c6a59d4a6ed13c6eec1
parenta0483b962dfbba051de2c0b1acbe268579a81f22
openssh: drop rejected patch fixed in 8.6p1 release

The rationale [1] is that C11 6.5.6.9 says:
"""
When two pointers are subtracted, both shall point to elements of the
same array object, or one past the last element of the array object; the
result is the difference of the subscripts of the two array elements.
"""

In these cases the objects are arrays of char so the result is defined,
and we believe that the compiler incorrectly trapping on defined behaviour.

I also found https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63303
("Pointer subtraction is broken when using -fsanitize=undefined") which seems to support this position.

[1] https://bugzilla.mindrot.org/show_bug.cgi?id=2608

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-connectivity/openssh/openssh/fix-potential-signed-overflow-in-pointer-arithmatic.patch [deleted file]
meta/recipes-connectivity/openssh/openssh_9.7p1.bb