]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commit
kernel: Fix path comparison in kernel staging dir symlinking
authorStaffan Rydén <staffan.ryden@axis.com>
Thu, 20 Jul 2023 11:02:56 +0000 (13:02 +0200)
committerSteve Sakoman <steve@sakoman.com>
Tue, 22 Aug 2023 17:07:13 +0000 (07:07 -1000)
commitcf2267f80ec44b24c627347df7efbd492a07dcfa
treec52dfbe110abfef1105e0ac0e268625db5a80bdb
parent007a57ce36a06f9a78675563020f24e1afa3caa1
kernel: Fix path comparison in kernel staging dir symlinking

Due to an oversight in the do_symlink_kernsrc function, the path
comparison between "S" and "STAGING_KERNEL_DIR" is broken. The code
obtains both variables, but modifies the local copy of "S" before
comparing them, causing the comparison to always return false.

This can cause the build to fail when the EXTERNALSRC flag is enabled,
since the code will try to create a symlink even if one already exists.

This patch resolves the issue by comparing the variables before they are
modified.

Signed-off-by: Staffan Rydén <staffan.ryden@axis.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
(cherry picked from commit afd2038ef8a66a5e6433be31a14e1eb0d9f9a1d3)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/classes/kernel.bbclass