]> git.ipfire.org Git - thirdparty/linux.git/commit
net: stmmac: mdio: fix incorrect phy address check
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 25 Oct 2025 18:35:47 +0000 (20:35 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Oct 2025 01:58:01 +0000 (18:58 -0700)
commitcf35f4347ddd42ceca156e57a87ec489788f1bd7
tree3e5174eb945337b5ea41be466d07e3d2785b7b16
parent10c7b9be47e683634535c360e75ec2a48e73b2ce
net: stmmac: mdio: fix incorrect phy address check

max_addr is the max number of addresses, not the highest possible address,
therefore check phydev->mdio.addr > max_addr isn't correct.
To fix this change the semantics of max_addr, so that it represents
the highest possible address. IMO this is also a little bit more intuitive
wrt name max_addr.

Fixes: 4a107a0e8361 ("net: stmmac: mdio: use phy_find_first to simplify stmmac_mdio_register")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Reported-by: Simon Horman <horms@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/e869999b-2d4b-4dc1-9890-c2d3d1e8d0f8@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c