]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: chipidea: fix missing goto in `ci_hdrc_probe`
authorYinhao Hu <dddddd@hust.edu.cn>
Wed, 12 Apr 2023 05:58:52 +0000 (13:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 09:11:43 +0000 (11:11 +0200)
commitcf70358b419c09e4c049b800e68da9f8c67e0458
tree93329d030fe9e6e06cec51cdb522ec9ce25f4cf2
parentbf1dad88b4a6793998247b8d26303a9f71305041
usb: chipidea: fix missing goto in `ci_hdrc_probe`

[ Upstream commit d6f712f53b79f5017cdcefafb7a5aea9ec52da5d ]

From the comment of ci_usb_phy_init, it returns an error code if
usb_phy_init has failed, and it should do some clean up, not just
return directly.

Fix this by goto the error handling.

Fixes: 74475ede784d ("usb: chipidea: move PHY operation to core")
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Acked-by: Peter Chen <peter.chen@kernel.org>
Signed-off-by: Yinhao Hu <dddddd@hust.edu.cn>
Link: https://lore.kernel.org/r/20230412055852.971991-1-dddddd@hust.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/chipidea/core.c