]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gpio/aspeed-sgpio: don't enable all interrupts by default
authorJeremy Kerr <jk@codeconstruct.com.au>
Fri, 11 Sep 2020 01:51:05 +0000 (09:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Oct 2020 06:02:52 +0000 (08:02 +0200)
commitcf7f69852717a58dbb50fa20ddf8b5e424647703
tree24e8f7898864967fe3a8baf7e3eea75e8dc1f2f9
parent7dc4222171ce25da56e3d23e9e5b19bb060d48f3
gpio/aspeed-sgpio: don't enable all interrupts by default

[ Upstream commit bf0d394e885015941ed2d5724c0a6ed8d42dd95e ]

Currently, the IRQ setup for the SGPIO driver enables all interrupts in
dual-edge trigger mode. Since the default handler is handle_bad_irq, any
state change on input GPIOs will trigger bad IRQ warnings.

This change applies sensible IRQ defaults: single-edge trigger, and all
IRQs disabled.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
Reviewed-by: Joel Stanley <joel@jms.id.au>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-aspeed-sgpio.c