]> git.ipfire.org Git - thirdparty/libvirt.git/commit
tests: Don't advertise VIR_TEST_EXPENSIVE to users
authorAndrea Bolognani <abologna@redhat.com>
Tue, 22 Sep 2020 11:41:49 +0000 (13:41 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 23 Sep 2020 09:30:05 +0000 (11:30 +0200)
commitcf81c85bf52cf1f985fc6494af1a797261a4bd0d
tree095a0403c6489b8fc6487a0d174b1f8ba0d2cf72
parent556fbc7f0227352a5a2ca591d2f79a608cebfeb4
tests: Don't advertise VIR_TEST_EXPENSIVE to users

Right now, the logic that takes care of deciding whether expensive
tests should be run or not is not working correctly: more
specifically, it's not possible to use something like

  $ VIR_TEST_EXPENSIVE=1 ninja test

to override the default choice, because in meson.build we always
pass an explicit value that overrides whatever is present in the
environment.

We could implement logic to make this work properly, but that
would require some refactoring of our test infrastructure and is
arguably of little value given that running

  $ meson build -Dexpensive_tests=enabled

is very fast, so let's just stop telling users about the variable
instead and call it a day.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
docs/advanced-tests.rst
meson_options.txt
tests/test-lib.sh