]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ionic: Prevent driver/fw getting out of sync on devcmd(s)
authorBrett Creeley <brett.creeley@amd.com>
Mon, 9 Jun 2025 21:28:27 +0000 (14:28 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:07:38 +0000 (11:07 +0100)
commitcf843efbc4c6996965703869f7acd730f496842a
treecdce4e83d6ec7424fea6a110f250397d4611d166
parent0891f7fc7596a7bf9e89600bfecb0e4fafddf461
ionic: Prevent driver/fw getting out of sync on devcmd(s)

[ Upstream commit 5466491c9e3309ed5c7adbb8fad6e93fcc9a8fe9 ]

Some stress/negative firmware testing around devcmd(s) returning
EAGAIN found that the done bit could get out of sync in the
firmware when it wasn't cleared in a retry case.

While here, change the type of the local done variable to a bool
to match the return type from ionic_dev_cmd_done().

Fixes: ec8ee714736e ("ionic: stretch heartbeat detection")
Signed-off-by: Brett Creeley <brett.creeley@amd.com>
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250609212827.53842-1-shannon.nelson@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/pensando/ionic/ionic_main.c