]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
acpi/arm64: Adjust error handling procedure in gtdt_parse_timer_block()
authorAleksandr Mishin <amishin@t-argos.ru>
Tue, 27 Aug 2024 10:12:39 +0000 (13:12 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:47:44 +0000 (19:47 +0100)
commitcf9efea8c09247a4b428cbdc542b10456a691dec
tree812c86be745f1552e791be09b1b6ef4248db876a
parent6c772871c2e5dc243ff27d1a4157a63ba4fc4866
acpi/arm64: Adjust error handling procedure in gtdt_parse_timer_block()

[ Upstream commit 1a9de2f6fda69d5f105dd8af776856a66abdaa64 ]

In case of error in gtdt_parse_timer_block() invalid 'gtdt_frame'
will be used in 'do {} while (i-- >= 0 && gtdt_frame--);' statement block
because do{} block will be executed even if 'i == 0'.

Adjust error handling procedure by replacing 'i-- >= 0' with 'i-- > 0'.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: a712c3ed9b8a ("acpi/arm64: Add memory-mapped timer support in GTDT driver")
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Acked-by: Hanjun Guo <guohanjun@huawei.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Aleksandr Mishin <amishin@t-argos.ru>
Link: https://lore.kernel.org/r/20240827101239.22020-1-amishin@t-argos.ru
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/arm64/gtdt.c