]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix memory leak when guc.c decides a setting can't be applied now.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 12 Oct 2020 17:31:24 +0000 (13:31 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 12 Oct 2020 17:31:24 +0000 (13:31 -0400)
commitcfa4cff30c3021597473178e1c6c5592f6437119
tree5b436bf7f098c389c2bc1df6140ed94eea184bc5
parente3868c7d59d4fb551c7159270b99656cc9ea7880
Fix memory leak when guc.c decides a setting can't be applied now.

The prohibitValueChange code paths in set_config_option(), which
are executed whenever we re-read a PGC_POSTMASTER variable from
postgresql.conf, neglected to free anything before exiting.  Thus
we'd leak the proposed new value of a PGC_STRING variable, as noted
by BoChen in bug #16666.  For all variable types, if the check hook
creates an "extra" chunk, we'd also leak that.

These are malloc not palloc chunks, so there is no mechanism for
recovering the leaks before process exit.  Fortunately, the values
are typically not very large, meaning you'd have to go through an
awful lot of SIGHUP configuration-reload cycles to make the leakage
amount to anything.  Still, for a long-lived postmaster process it
could potentially be a problem.

Oversight in commit 2594cf0e8.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/16666-2c41a4eec61b03e1@postgresql.org
src/backend/utils/misc/guc.c