]> git.ipfire.org Git - thirdparty/linux.git/commit
perf hwmon: Fix fd check to accept fd 0 in hwmon_pmu__describe_items()
authorArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 10 Jun 2026 23:40:34 +0000 (20:40 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 17 Jun 2026 11:28:47 +0000 (08:28 -0300)
commitcfafef390ca9c753b34c7e97b5abee4cab0ce270
tree96e5cc144112aac4f6e63fcc7d383f4562f187eb
parent7b0df6f4d498b1608afccfd6dffb264e6da91693
perf hwmon: Fix fd check to accept fd 0 in hwmon_pmu__describe_items()

hwmon_pmu__describe_items() checks 'if (fd > 0)' after openat(), which
incorrectly rejects fd 0.  While fd 0 is normally stdin, if stdin has
been closed (common in daemon/service contexts), the kernel reuses fd 0
for the next open.  With fd > 0, the sysfs file is not read and the fd
is leaked.

Change to 'if (fd >= 0)' to match the standard openat() error check.

Reported-by: sashiko-bot <sashiko-bot@kernel.org>
Fixes: 53cc0b351ec99278 ("perf hwmon_pmu: Add a tool PMU exposing events from hwmon in sysfs")
Reviewed-by: Ian Rogers <irogers@google.com>
Cc: Ian Rogers <irogers@google.com>
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/hwmon_pmu.c