]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Don't overwrite socket flags when using DCO on Windows
authorLev Stipakov <lev@openvpn.net>
Fri, 24 Mar 2023 12:18:18 +0000 (14:18 +0200)
committerGert Doering <gert@greenie.muc.de>
Fri, 24 Mar 2023 12:36:42 +0000 (13:36 +0100)
commitcfc5228f9aeaa99c75fb7538435780e4dd7fb7de
treebf9a33c3b579af3adbaef900a9694b35c800cd3c
parent5a189d5e249c89c55ef7cad4d19a9d8e89a20ff1
Don't overwrite socket flags when using DCO on Windows

Socket flags can be pushed, in which case they overwrite
existing value. We use socket flags to distingust between
DCO handle and socket on Windows. If server pushes --socket-flags,
we treat DCO handle as socket and everything explodes.

Fix by making link_socket_update_flags() update flags
(like name suggests) instead of overwriting them. Also
do not set TCP_NODELAY on DCO handle on Windows because
it doesn't make sense.

Change-Id: Ia34d73ca49041cb0ce22b84751cdbff57de96048
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20230324121818.2358-1-lstipakov@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26513.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 82e7d5cfd81f03f045ace2bf1d3590b79441ea17)
src/openvpn/socket.c