]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: atlantic: fix potential error handling
authorPavel Belous <pbelous@marvell.com>
Fri, 14 Feb 2020 15:44:56 +0000 (18:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Mar 2020 15:45:20 +0000 (16:45 +0100)
commitcfde03060aa396a3b537781f81874d2a9ca0529e
treec63057eb5f7f8150da9655594d4ba2207384ad61
parent7b288eb4f7aeceee3980ba01f28fc341fbb90556
net: atlantic: fix potential error handling

commit 380ec5b9af7f0d57dbf6ac067fd9f33cff2fef71 upstream.

Code inspection found that in case of mapping error we do return current
'ret' value. But beside error, it is used to count number of descriptors
allocated for the packet. In that case map_skb function could return '1'.

Changing it to return zero (number of mapped descriptors for skb)

Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code")
Signed-off-by: Pavel Belous <pbelous@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: Dmitry Bogdanov <dbogdanov@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/aquantia/atlantic/aq_nic.c