]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
thunderbolt: Reject zero-length property entries in validator
authorMichael Bommarito <michael.bommarito@gmail.com>
Mon, 25 May 2026 09:28:25 +0000 (05:28 -0400)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Tue, 26 May 2026 13:18:18 +0000 (15:18 +0200)
commitcff8eb65d1eafe7793e54b4d0cf6bf831644630b
tree251152a562265c92e0eb830f846f217951ed55f0
parent928abe19fbf0127003abcb1ea69cabc1c897d0ab
thunderbolt: Reject zero-length property entries in validator

tb_property_entry_valid() accepts entries with length == 0 for
DIRECTORY, DATA, and TEXT types.  A zero-length TEXT entry passes
validation but causes an underflow in the null-termination logic:

  property->value.text[property->length * 4 - 1] = '\0';

When property->length is 0 this writes to offset -1 relative to
the allocation.

Reject zero-length entries early in the validator since they have no
valid representation in the XDomain property protocol.

Fixes: cdae7c07e3e3 ("thunderbolt: Add support for XDomain properties")
Cc: stable@vger.kernel.org
Assisted-by: Claude:claude-opus-4-7
Signed-off-by: Michael Bommarito <michael.bommarito@gmail.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/property.c