]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: ccree - Fix use after free in cc_cipher_exit()
authorJianglei Nie <niejianglei2021@163.com>
Thu, 3 Mar 2022 02:23:37 +0000 (10:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 11:57:38 +0000 (13:57 +0200)
commitcffb5382bd8d3cf21b874ab5b84bf7618932286b
treefa78639b2d9628960c51e5f79aec77154c36d0d3
parent698f3d40321bb1c46fbee121325bde24269e7c3a
crypto: ccree - Fix use after free in cc_cipher_exit()

[ Upstream commit 3d950c34074ed74d2713c3856ba01264523289e6 ]

kfree_sensitive(ctx_p->user.key) will free the ctx_p->user.key. But
ctx_p->user.key is still used in the next line, which will lead to a
use after free.

We can call kfree_sensitive() after dev_dbg() to avoid the uaf.

Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support")
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/ccree/cc_cipher.c