]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
libata: Align ata_device's id on a cacheline
authorHarvey Hunt <harvey.hunt@imgtec.com>
Wed, 24 Feb 2016 15:16:43 +0000 (15:16 +0000)
committerSasha Levin <sasha.levin@oracle.com>
Wed, 9 Mar 2016 18:15:10 +0000 (13:15 -0500)
commitd017f850a3b6f84e6d847c6cbb01eaf6ce61f4f6
tree022247ebdb4689a15b407b1a6658755c9fec1061
parent15115bf3b764c4f2b36ea202f45181fd18d4a574
libata: Align ata_device's id on a cacheline

[ Upstream commit 4ee34ea3a12396f35b26d90a094c75db95080baa ]

The id buffer in ata_device is a DMA target, but it isn't explicitly
cacheline aligned. Due to this, adjacent fields can be overwritten with
stale data from memory on non coherent architectures. As a result, the
kernel is sometimes unable to communicate with an ATA device.

Fix this by ensuring that the id buffer is cacheline aligned.

This issue is similar to that fixed by Commit 84bda12af31f
("libata: align ap->sector_buf").

Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: linux-kernel@vger.kernel.org
Cc: <stable@vger.kernel.org> # 2.6.18
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
include/linux/libata.h