]> git.ipfire.org Git - thirdparty/linux.git/commit
usb: typec: ucsi: Invert DisplayPort role assignment
authorAndrei Kuchynski <akuchynski@chromium.org>
Mon, 1 Jun 2026 14:28:37 +0000 (14:28 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jun 2026 14:11:41 +0000 (15:11 +0100)
commitd092d7edf8faefa3e27b9fc7f0e7904b06c833a2
treed95eb1212adfdea19eecdd912403326bf15af2e0
parent8af6812795869a66e9b26044f455b13deecdb69c
usb: typec: ucsi: Invert DisplayPort role assignment

The existing implementation assigned these flags backwards, configuring
the partner's DisplayPort role to match the port's role instead of
complementing it.
This prevents proper configuration during DP altmode activation, often
causing `pin_assignment` to remain 0 in `dp_altmode_configure()` and
resulting in VDM negotiation failures:

    [  583.328246] typec port1.1: VDM 0xff01a150 failed

Additionally, the fix ensures that the `pin_assignment` sysfs attribute
displays the correct values.

Cc: stable <stable@kernel.org>
Fixes: af8622f6a585 ("usb: typec: ucsi: Support for DisplayPort alt mode")
Signed-off-by: Andrei Kuchynski <akuchynski@chromium.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://patch.msgid.link/20260601142837.3240207-1-akuchynski@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/ucsi/displayport.c