]> git.ipfire.org Git - thirdparty/linux.git/commit
media: ov02c10: Adjust x-win/y-win when changing flipping to preserve bayer-pattern
authorHans de Goede <johannes.goede@oss.qualcomm.com>
Mon, 8 Dec 2025 14:12:58 +0000 (15:12 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 6 Jan 2026 08:33:32 +0000 (09:33 +0100)
commitd0bb6f1f2b79d96953bf81a3839ac2aa946ba2fa
tree791105bf02ebe72ad6d6c6ca8ced03487217928c
parent905120d7470e5ed79d59b61ef6aa13344ffca229
media: ov02c10: Adjust x-win/y-win when changing flipping to preserve bayer-pattern

The ov02c10 is capable of having its (crop) window shifted around with 1
pixel precision while streaming.

This allows changing the x/y window coordinates when changing flipping to
preserve the bayer-pattern.

__v4l2_ctrl_handler_setup() will now write the window coordinates at 0x3810
and 0x3812 so these can be dropped from sensor_1928x1092_30fps_setting.

Since the bayer-pattern is now unchanged, the V4L2_CTRL_FLAG_MODIFY_LAYOUT
flag can be dropped from the flip controls.

Note the original use of the V4L2_CTRL_FLAG_MODIFY_LAYOUT flag was
incomplete, besides setting the flag the driver should also have reported
a different mbus code when getting the source pad's format depending on
the hflip / vflip settings see the ov2680.c driver for example.

Fixes: b7cd2ba3f692 ("media: ov02c10: Support hflip and vflip")
Cc: stable@vger.kernel.org
Reviewed-by: Bryan O'Donoghue <bod@kernel.org>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
Tested-by: Sebastian Reichel <sre@kernel.org> # T14s Gen6 Snapdragon
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov02c10.c